Fix k5test minimum version requirement #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test function test_set_password fails when run with k5test 0.10.3. ``` TypeError: MITRealm.start_kadmind() missing 1 required positional argument: 'env' ``` This is because it is running the start_kadmind method with no arguments, but the env argument didn't become optional until k5test 0.10.4. That is now the new minimum version for this test dependency. jborean93@4cbfe7d pythongssapi/k5test@aa9cf87
jborean93
approved these changes
Oct 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test function test_set_password fails when run with k5test 0.10.3.
This is because it is running the start_kadmind method with no arguments, but the env argument didn't become optional until k5test 0.10.4. That is now the new minimum version for this test dependency.
4cbfe7d
pythongssapi/k5test@aa9cf87